Add support for znode flag #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the aurora scheduler znode to be passed as a flag at runtime.
tommyulfsparre
requested changes
Feb 23, 2017
finder.go
Outdated
| zkLeaderPrefix = "singleton_candidate_" | ||
| ) | ||
|
|
||
| type finder interface { | ||
| leaderURL() (string, error) | ||
| } | ||
|
|
||
| func newFinder(url string) (f finder, err error) { | ||
| func newFinder(url string, znode string) (f finder, err error) { |
There was a problem hiding this comment.
nit: you only need to specify the type once: url, znode string
finder.go
Outdated
| @@ -86,7 +85,7 @@ type zkFinder struct { | |||
| leaderIP string | |||
| } | |||
|
|
|||
| func newZkFinder(url string) *zkFinder { | |||
| func newZkFinder(url string, znode string) *zkFinder { | |||
main.go
Outdated
| @@ -21,6 +21,7 @@ var ( | |||
| addr = flag.String("web.listen-address", ":9113", "Address to listen on for web interface and telemetry.") | |||
| auroraURL = flag.String("exporter.aurora-url", "http://127.0.0.1:8081", "URL to an Aurora scheduler or ZooKeeper ensemble") | |||
| metricPath = flag.String("web.telemetry-path", "/metrics", "Path under which to expose metrics.") | |||
| zkPath = flag.String("zk.path", "/aurora/scheduler", "zkNode that aurora matains master election.") | |||
finder.go
Outdated
| @@ -15,21 +15,20 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
nit: remove the parentheses
spelling and formatting corrections
|
@tommyulfsparre do you have any preferences regarding how best to resolve this? Do you want to support |
tommyulfsparre
approved these changes
Feb 24, 2017
|
@zircote so I think of not adding curator support for now and later support both, toggled with a cmdline flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the aurora scheduler znode to be passed as
a flag at runtime. We rely on zk for multiple clusters and to enable this to work for us
it become necessary to allow us to direct the scraper to the correct znode. Let me know
your feedback on the pr looking forward to hearing back.